Optimize the logging in AbstractDeleteStrategy - Known Error

Optimize the logging in AbstractDeleteStrategy Description In Discovery log, it shows: AbstractDeleteStrategy: Exceeded the maximum number of deletions (2000) in one pattern. Increase the number property: glide.discovery.delete_strategy.max_deletion_records to be able to trigger more deletions. However this does not show the triggering pattern / ecc thus it will be hard to further investigations. In Node log, we see undefined: 2021-03-30 03:09:49 (584) worker.1 worker.1 txid=bc2fabc8db9f *** Script: Removing related entries in : undefined for CI : dae139041bd32410bb3143fccc4bcbe5 2021-03-30 03:09:49 (585) worker.1 worker.1 txid=bc2fabc8db9f *** Script: Marking CI dae139041bd32410bb3143fccc4bcbe5 as retired ... 2021-03-30 03:09:46 (989) worker.1 worker.1 txid=bc2fabc8db9f *** Script: Removing related entries in : undefined for CI : efe2a98c1b97e010bb3143fccc4bcbc5 2021-03-30 03:09:46 (990) worker.1 worker.1 txid=bc2fabc8db9f *** Script: Removing related entries in : cmdb_key_value for CI : efe2a98c1b97e010bb3143fccc4bcbc5 .. 2021-03-30 03:10:38 (129) worker.1 worker.1 txid=bc2fabc8db9f *** Script: Marking CI 72c9aa971b69ec5007fd43fccc4bcb9b as retired 2021-03-30 03:10:38 (144) worker.1 worker.1 txid=bc2fabc8db9f *** Script: Removing related entries in : undefined for CI : 0c42cc77dba31c1014598a1705961925 2021-03-30 03:10:38 (145) worker.1 worker.1 txid=bc2fabc8db9f *** Script: Marking CI 0c42cc77dba31c1014598a1705961925 as retired Steps to Reproduce

After CAPI to Pattern migration, "Amazon AWS - Storage (LP)" probe can throw this. To test, set glide.discovery.delete_strategy.max_deletion_records to lower, maybe 5.

Make sure CAPI to Pattern migration completed for AWS On AWS, create 5 storage volumes, run Cloud Discovery for AWS service account On AWS, delete the 5 storage volumes, run Cloud Discovery again Example :

Having 10000 stale records for LDC "A" after migrating from CAPI to Patterns (or any case that could cause a large number of records to be treated as stale). Discovery runs pattern which discovers LDC "A". What happens next is the following.

Pattern creates CIs in the CMDB related to the data from the pattern. Once last page finishes processing, delete strategy is launched. Delete strategy begins deleting the 10000 stale records left in the CMDB from when CAPI was in use. Once it deletes 2000, it sends the logging message the customer saw "AbstractDeleteStrategy: Exceeded the maximum number of deletions (2000) in one pattern". Delete strategy stops deleting stale records at this point. After processing, we have the following: 8000 stale CMDB items, and the new CMDB items created by the pattern.

If we run the pattern again (assuming none of the CIs that were just added get marked as stale), once we reach the delete strategy stage, it will delete 2000 stale records again and then we have have 6000 left. Eventually, the CMDB is going to get into a state where there are less than 2000 stale records left, and from this point the message will no longer appear as it won't be hitting the limit. This is what we believe is causing customer to no longer see the issue. After running discoveries enough times, customer has reached a "clean" state for their cmdb and the stale records from CAPI are now gone for the Patterns/LDCs that they have been running discovery on. It is important to note that the message could re-appear again if the customer had a major overall in their own cloud environment, such that over 2000 CIs would be marked as stale for a given LDC/Pattern. However, just like before this would disappear after running discovery more times. Reference :

After CAPI to Pattern migration, discovery log may have warning: AbstractDeleteStrategy: Exceeded the maximum number of deletions (2000) in one pattern. Increase the number property: glide.discovery.delete_strategy.max_deletion_records Workaround This problem has been fixed. If you are able to upgrade, review the Fixed In or Intended Fix Version fields to determine whether any versions have a planned or permanent fix.